Kdecoration2 ->KDecoration3 Fixes #30
Added a naive null check for transient Added the nextStateChanged handler (not sure if correct) Added deco->create call to init the state Run time tested X11 not wayland
Thanks for the PR.
https://github.com/winft/theseus-ship/issues/9 has been merged.
Can you check on @jbeich's other comments?
Can you check on @jbeich's other comments?
- 7ad1bc1d9b7b is fine by me and was applied downstream
- Maybe add "Fixes https://github.com/winft/como/issues/30" to the PR description in order to automatically close it on merge
Note this is Qt >=6.9 only as they renamed a private header to QtGui/private/qdesktopunixservices_p.h in https://github.com/qt/qtbase/commit/7ab7d88e8aa4abb932259267b515f730075b9bfe
Note this is Qt >=6.9 only as they renamed a private header to QtGui/private/qdesktopunixservices_p.h in qt/qtbase@7ab7d88
That's fine.
The PR looks good to me. If there is nothing else can you @jsm222 add "Fixes #30" to the PR description so this PR closes the issue automatically on merge like was proposed?