como icon indicating copy to clipboard operation
como copied to clipboard

Kdecoration2 ->KDecoration3 Fixes #30

Open jsm222 opened this issue 6 months ago • 4 comments

Added a naive null check for transient Added the nextStateChanged handler (not sure if correct) Added deco->create call to init the state Run time tested X11 not wayland

jsm222 avatar Jun 18 '25 21:06 jsm222

Thanks for the PR.

https://github.com/winft/theseus-ship/issues/9 has been merged.

Can you check on @jbeich's other comments?

romangg avatar Jun 26 '25 07:06 romangg

Can you check on @jbeich's other comments?

jbeich avatar Jun 26 '25 10:06 jbeich

Note this is Qt >=6.9 only as they renamed a private header to QtGui/private/qdesktopunixservices_p.h in https://github.com/qt/qtbase/commit/7ab7d88e8aa4abb932259267b515f730075b9bfe

jsm222 avatar Jun 26 '25 14:06 jsm222

Note this is Qt >=6.9 only as they renamed a private header to QtGui/private/qdesktopunixservices_p.h in qt/qtbase@7ab7d88

That's fine.

The PR looks good to me. If there is nothing else can you @jsm222 add "Fixes #30" to the PR description so this PR closes the issue automatically on merge like was proposed?

romangg avatar Jun 27 '25 14:06 romangg