UnrealEngine_NVIDIAGameWorks icon indicating copy to clipboard operation
UnrealEngine_NVIDIAGameWorks copied to clipboard

I want to update this branch to UE4 4.19 ,do you have any suggestion?

Open Lz15984878289 opened this issue 6 years ago • 8 comments

I find a problem with UE4 4.18 that when creating a new C++ project.It can not open visual studio 2017 .So I want to update this branch to UE4 4.19.Can you tell me how did you merge this branch to UE4 4.18?Thanks very much

Lz15984878289 avatar Mar 30 '18 09:03 Lz15984878289

i used VS 2015, i think it's stable for custom build now 😄

windystrife avatar Apr 23 '18 10:04 windystrife

I have find the problem where it is. In this file:\Engine\Source\Programs\UnrealBuildTool\Platform\Windows\UEBuildWindows.cs.

` // Second, default based on what's installed, test for 2015 first DirectoryReference VCInstallDir;

if (TryGetVCInstallDir(WindowsCompiler.VisualStudio2015, out VCInstallDir))
{
    return WindowsCompiler.VisualStudio2015;
}
if (TryGetVCInstallDir(WindowsCompiler.VisualStudio2017, out VCInstallDir))
{
    return WindowsCompiler.VisualStudio2017;
}

` and if you have installed VS2017 but didn't install VS2015
this functionalso return true.

TryGetVCInstallDir(WindowsCompiler.VisualStudio2015, out VCInstallDir)

So I have change the order of these function ,like this ` // Second, default based on what's installed, test for 2017 first DirectoryReference VCInstallDir;

    if (TryGetVCInstallDir(WindowsCompiler.VisualStudio2017, out VCInstallDir))
    {
        return WindowsCompiler.VisualStudio2017;
    }
      if (TryGetVCInstallDir(WindowsCompiler.VisualStudio2015, out VCInstallDir))
    {
        return WindowsCompiler.VisualStudio2015;
    }

` And it works well now.

Lz15984878289 avatar Apr 24 '18 02:04 Lz15984878289

By the way, in your branch,it has lost some files of Flex because of the gitignore file.Maybe you can add it.

Lz15984878289 avatar Apr 24 '18 02:04 Lz15984878289

i don't see any missing flex files yet, can you show me??

windystrife avatar Apr 24 '18 09:04 windystrife

The flex editor lost a icon file. you can get it there : https://github.com/NvPhysX/UnrealEngine/tree/FleX-4.17.1/Engine/Content/Editor/Slate/Icons

Lz15984878289 avatar Apr 24 '18 12:04 Lz15984878289

Any update to make this in UE4.19???

HypnosVR avatar May 10 '18 03:05 HypnosVR

so excited about getting this to UE4.20

Zimbower avatar Aug 23 '18 15:08 Zimbower

hope to simplify how waveworks implement into 4.20!

On Thu, Aug 23, 2018 at 11:22 PM Bojan [email protected] wrote:

so excited about getting this to UE4.20

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/windystrife/UnrealEngine_NVIDIAGameWorks/issues/2#issuecomment-415457392, or mute the thread https://github.com/notifications/unsubscribe-auth/AZjE71Phura_KmKjgqyVfle5fPnVd2gQks5uTsjCgaJpZM4TBfl5 .

kalng avatar Aug 24 '18 01:08 kalng