ThirdTube icon indicating copy to clipboard operation
ThirdTube copied to clipboard

240p and below doesn’t work (except off) and unknown image format

Open SleepyBoi2852 opened this issue 4 years ago • 7 comments

So I was trying to document an error where 240p and below wouldn't work, and I encountered a new error. Here are 2 videos where I didn't encounter the error since the one with the error won't upload https://user-images.githubusercontent.com/35126957/137622800-1fed2202-db5f-4501-974f-d4b4d64a6755.MOV And here is the image format error image

SleepyBoi2852 avatar Oct 17 '21 10:10 SleepyBoi2852

Also it crashes after exiting the app after the image error thing image

SleepyBoi2852 avatar Oct 17 '21 10:10 SleepyBoi2852

Thank you for reporting. For the crash-on-exit thing, I think it's the same as #13. Anyway I was able to find a possible cause of the crash from the crash dump you provided. It seems that the decoder shows an error when the size of the 240p and 144p streams of the video is smaller than a certain value. (it can also happen with 360p streams if it's sufficiently small) And I feel like the thumbnail problem is an independent network issue.

By the way, it would be appreciated if you could open separate issues for separate problems so that when some of them are fixed we can close the corresponding issues, which makes it easier to find remaining issues.

windows-server-2003 avatar Oct 18 '21 15:10 windows-server-2003

It turned out that the failure of 240p and below is caused by OTF format streams used by YouTube (I don't know what it is but that's how they call it) I can support them but currently those formats seem to be rare, so I'm removing the resolution option if it's in OTF format for now. I'm keeping this open as this is something that should be properly fixed in the future.

windows-server-2003 avatar Nov 18 '21 09:11 windows-server-2003

Implemented the temporal solution in v0.4.0. I'm keeping this open until I implement a full solution.

windows-server-2003 avatar Nov 28 '21 15:11 windows-server-2003

Implemented the temporal solution in v0.4.0. I'm keeping this open until I implement a full solution.

not to be rude but do you mean "temporary" instead of "temporal"?

SleepyBoi2852 avatar Nov 29 '21 04:11 SleepyBoi2852

also it the resolution thing works now

SleepyBoi2852 avatar Nov 29 '21 04:11 SleepyBoi2852

not to be rude but do you mean "temporary" instead of "temporal"?

Exactly! Thanks for pointing out.

windows-server-2003 avatar Dec 15 '21 03:12 windows-server-2003