windmill icon indicating copy to clipboard operation
windmill copied to clipboard

fix(frontend): prevent multiple menu opening

Open Guilhem-lm opened this issue 8 months ago • 2 comments

[!IMPORTANT] Prevent multiple menu openings by using unique modalId and excluding these IDs from click outside events.

  • Behavior:
    • Prevents multiple menu openings by introducing modalId in AppButton.svelte and AppMenu.svelte.
    • Excludes modalId from click outside events in Menu.svelte to prevent closing other menus.
  • Components:
    • Adds modalId and modalWrapperClass props to ConfirmationModal.svelte.
    • Calls onSuccess callback in AppButton.svelte after setting list inputs.
  • Misc:
    • Uses crypto.randomUUID() to generate unique modalId in AppMenu.svelte.
    • Adjusts getMenuElements() in Menu.svelte to include elements with modalId.

This description was created by Ellipsis for 04f7b03ad5084840bef10a6a8dabc7b01e7f16d3. You can customize this summary. It will automatically update as commits are pushed.

Guilhem-lm avatar Apr 21 '25 13:04 Guilhem-lm

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 04f7b03
Status: ✅  Deploy successful!
Preview URL: https://5bc8abcd.windmill.pages.dev
Branch Preview URL: https://glm-fix-frontend-prevent-mul.windmill.pages.dev

View logs

This PR fixes #5739

Guilhem-lm avatar May 28 '25 06:05 Guilhem-lm