windmill icon indicating copy to clipboard operation
windmill copied to clipboard

Migration/queue params

Open yacineb opened this issue 1 year ago • 1 comments

[!IMPORTANT] This pull request adds new database tables for job parameters, refactors job handling code, and introduces macros for database query fallbacks.

  • Database Migrations:
    • Add job_params, job_args, and completed_jobs_result tables with corresponding up and down SQL scripts.
    • Modify job_params table to include workspace_id and remove args column.
    • Add tag column to job_params table.
  • Code Refactoring:
    • Update monitor.rs to handle job cancellation with new parameters.
    • Refactor inputs.rs to use query_scalar_with_fallback! for fetching job arguments.
    • Modify jobs.rs to handle job cancellation and result storage in completed_jobs_result.
    • Refactor worker_flow.rs to use fetch_one_with_fallback! and fetch_optional_with_fallback! macros for database queries.
  • Macros and Utilities:
    • Add macros.rs with fetch_one_with_fallback! and fetch_optional_with_fallback! macros for database query fallbacks.
    • Implement FlowStatusGetter and FlowValueGetter traits in flow_status.rs and flows.rs.
  • Miscellaneous:
    • Add const_format dependency in Cargo.toml for string formatting in macros.
    • Update .gitignore to include !build/.gitkeep.

This description was created by Ellipsis for 6411de2489fd3d6ddbde24aac6438f85a78ebea9. It will automatically update as commits are pushed.

yacineb avatar Oct 04 '24 11:10 yacineb

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


0 out of 2 committers have signed the CLA.
:x: @yacine Bouraroui
:x: @yacineb
yacine Bouraroui seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

github-actions[bot] avatar Oct 04 '24 11:10 github-actions[bot]

subsumed by 4625

rubenfiszel avatar Nov 02 '24 18:11 rubenfiszel