windmill icon indicating copy to clipboard operation
windmill copied to clipboard

feat(frontend) Change summary edition

Open Guilhem-lm opened this issue 1 year ago • 4 comments

Modifying the title input in order to not have it display as an input field.

  • Before : image image image

  • After :

    • Empty image
    • Hover Capture d’écran de 2024-06-28 09-04-39
    • focus Capture d’écran de 2024-06-28 09-10-23
    • dark/light image image

:rocket: This description was created by Ellipsis for commit 54294ba1b4e80d0aff39b8d13b7ea456571979f9

Summary:

Updated ScriptBuilder.svelte to change the appearance of the title input field using the new app-title class in app.css.

Key points:

  • Updated frontend/src/lib/components/ScriptBuilder.svelte to change the appearance of the title input field.
  • Added app-title class in frontend/src/lib/assets/app.css for styling the title input field.
  • The app-title class removes the border and adds hover and focus effects.
  • The title input field no longer displays as a traditional input field but as a styled text element.

Generated with :heart: by ellipsis.dev

Guilhem-lm avatar Jun 28 '24 08:06 Guilhem-lm

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
:white_check_mark: (fatonramadani)[https://github.com/fatonramadani]
:x: @Guilhem Le Mouel
Guilhem Le Mouel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

github-actions[bot] avatar Jun 28 '24 08:06 github-actions[bot]

It's now hard to discover you can edit it by clicking on it. You at very least need a pen next to it or similar

rubenfiszel avatar Jun 28 '24 08:06 rubenfiszel

It's now hard to discover you can edit it by clicking on it. You at very least need a pen next to it or similar

Yes I agree, i was thinking of :

  • changing the placeholder with "write a short summary here"
  • We can also have a default summary for new scripts being "untitled". That way the user understand the title is not set. There is also a text indication when hovering that display "rename". image image

Guilhem-lm avatar Jun 28 '24 11:06 Guilhem-lm

All the ideas are good but we use the clickable Pen icon next to a text to make it editable as a pattern in a few places, it's more consistent to keep it here and compatible with your other suggestions. Please apply it first so we can merge this

rubenfiszel avatar Jun 28 '24 11:06 rubenfiszel