zotero-types icon indicating copy to clipboard operation
zotero-types copied to clipboard

Fix ItemTreeManager registerColumns example

Open Dominic-DallOsto opened this issue 1 year ago • 3 comments

The width parameter should be a string, but it was a number

Dominic-DallOsto avatar Sep 08 '24 14:09 Dominic-DallOsto

Is there a reason that width is a string and minWidth a number?

Dominic-DallOsto avatar Sep 08 '24 15:09 Dominic-DallOsto

I looked into the source code of Zotero and it seems like the type def is from https://github.com/zotero/zotero/blob/42219772a73a0d7270d52494992aad6989f4c418/chrome/content/zotero/itemTreeColumns.jsx#L351-L352

But actually I guess it does not matter, as the width/minWidth will be wrapped with parseInt and both number/string would work.

windingwind avatar Sep 08 '24 20:09 windingwind

Thanks for the finding. We can mark them all as number.

windingwind avatar Sep 08 '24 20:09 windingwind

Sorry for the delay - is that better?

Dominic-DallOsto avatar Oct 13 '24 21:10 Dominic-DallOsto

Thanks for the PR:)

windingwind avatar Oct 13 '24 22:10 windingwind