zotero-pdf-preview icon indicating copy to clipboard operation
zotero-pdf-preview copied to clipboard

Enable/Disable preview panes

Open mjthoraval opened this issue 1 year ago • 4 comments

I am a bit confused on what the option "Enable Preview" should be doing in the Zotero Preferences. image If I disable this option, the Preview in Info Tab stays there, but keeps the last loaded preview, and does not change anymore when switching items. If I disable "Enable Preview" and "Preview in Preview Tab", a ghost Preview Tab still remains.

A Zotero restart clears the preview, but both ghost preview panes remain: image

Should the option "Enable Preview" be a master control of "Preview in Info Tab" & "Preview in Preview Tab"? In that case these two secondary options should be disabled when switching off "Enable Preview". Or is there another use case for this option?

mjthoraval avatar Oct 14 '22 05:10 mjthoraval

Fixed in v0.3.3. Currently it requires restarting Zotero to apply.

This option will be removed in the future, as in Zotero 7 all plugins can be disabled without restarting.

windingwind avatar Oct 14 '22 12:10 windingwind

Thank you for your quick replies. I am still facing some issues: the Preview in Info Tab stays empty, even though it is activated: image Restarting does not solve the problem. The Preview in Preview Tab is working fine for the same PDF file: image

I get the following error when clicking on a new item seeing the Preview in Info Tab: [JavaScript Error: "TypeError: iframe is null" {file: "chrome://pdfpreview/content/scripts/index.js" line: 402}]

mjthoraval avatar Oct 14 '22 17:10 mjthoraval

@mjthoraval see #30

volatile-static avatar Oct 15 '22 08:10 volatile-static

fixed.

windingwind avatar Oct 15 '22 11:10 windingwind

Thank you very much for the fix. I confirm that it is working fine now.

mjthoraval avatar Oct 16 '22 11:10 mjthoraval