windicss icon indicating copy to clipboard operation
windicss copied to clipboard

Preflight mismatches between tailwind and windi

Open mildlyfunctional opened this issue 4 years ago • 3 comments

for instance:

button:focus {
  outline: 1px dotted;
  outline: 5px auto -webkit-focus-ring-color;
}

should not be in preflight

mildlyfunctional avatar Oct 29 '21 16:10 mildlyfunctional

This is work in progress, but some guidance is appreciated:

  1. Why is this here? Should it not be part of 'base'? I left it in here for now: https://github.com/mrwokkel/windicss/blob/main/src/lib/utilities/preflight.ts#L305

  2. Should the process of keeping the file in sync with tailswinds version not be more automated? Would you like me to explore?

  3. Will the way of how the preflight css is added change in v4, or will it continue this path?

mildlyfunctional avatar Nov 01 '21 07:11 mildlyfunctional

  1. Actually I am not really familiar with it, /cc @voorjaar any idea?
  2. Currently keep syncing with tailwind is indeed one of the things we need to do. Free feel to give it a try.
  3. Not so sure yet, but I am considering not do preflight scanning but just appending a plain CSS file to it to improve the performance also make the result more stable. That's something we need to explore a bit tho.

antfu avatar Nov 01 '21 18:11 antfu

also the focus tag will have default margins (on firefox) although tailwind preflight should set them to 0

gaultierq avatar Jun 05 '22 01:06 gaultierq