Universal-G-Code-Sender icon indicating copy to clipboard operation
Universal-G-Code-Sender copied to clipboard

- forced CellRenderer to have the same width as the tree.

Open dnikodem84 opened this issue 6 months ago • 7 comments

  • this should fix: https://github.com/winder/Universal-G-Code-Sender/issues/2828

dnikodem84 avatar Jul 10 '25 08:07 dnikodem84

I have been fiddling with back and forth and never got this to work properly.

And it is not completely fixed with your changes. It will for instance become empty when loading a new file. The width of the tree item will also be static.

https://github.com/user-attachments/assets/5401f7e0-7237-4ec3-b720-b94402b19202

breiler avatar Jul 12 '25 06:07 breiler

Let me take a look at this again.

I have found a few other issues with the control ( After certain merge operations sometimes the position of the controls gets completely lost ) so there has to be something weird in the controls setup.

dnikodem84 avatar Jul 12 '25 06:07 dnikodem84

@breiler , It is unclear why my branch is failing test cases at the moment. Are you Able to offer any insight ?

dnikodem84 avatar Jul 12 '25 08:07 dnikodem84

There is a Async-test that is a bit flaky.

breiler avatar Jul 12 '25 08:07 breiler

Makes sense, Seems to have passed tests this time around.

dnikodem84 avatar Jul 12 '25 08:07 dnikodem84

It is still wonky for me. Both the design objects tree and the line width setting: image

Regarding the line width, I don't get how it is supposed to work or the use case. If I have a 10x10mm On-path operation, and I set the line width to 3.0+0.01mm the shape will be buffered with 3.01mm: image

image

breiler avatar Jul 17 '25 07:07 breiler

The branch was polluted with a different changes which I have not finished with yet ( the line width changes belong to: https://github.com/winder/Universal-G-Code-Sender/issues/2808 , Purpose of that changeset is to eventually expose all of the functionality in java.awt.BasicStroke to the user for path operations )

dnikodem84 avatar Jul 17 '25 07:07 dnikodem84

Closing this as this no longer seems to be a problem in the master branch.

breiler avatar Dec 15 '25 18:12 breiler