Greg Hurrell
Greg Hurrell
Going to do a mass-transfer of issues (including this one): - **From:** https://github.com/liferay/liferay-js-toolkit/issues - **To:** https://github.com/liferay/liferay-frontend-projects/issues Note that many of the issues that we move may be stale, but we...
Step 1 here, I suggest, would be compiling a list of places where we're using key events, to get a sense of how key codes are being used, and how...
> We consider moving to standardize key instead of keyCodes Probably. We'd need to tackle this on two fronts: in React (synthentic events) and in JS using native DOM events....
> One tricky part of this is that we also need to add some sort of filter on the DXP side for serving the correct bundle. Right now, every module...
> Throughout portal we tend to add JS in a variety of ways, any idea where we might investigate adding the two script tags? Or would this potentially just be...
> ESModules vs The Rest™️ > > `frontend-js-web` > ESModules: 2.2mb > The Rest: 2.3mb One other thing about this; it's not only about size. There's also a benefit in...
> Definitely not a filter. We usually do this through the `Servlet` that serves the files. The most obvious example being [RTLServlet](https://github.com/liferay/liferay-portal/blob/master/modules/apps/frontend-css/frontend-css-rtl-servlet/src/main/java/com/liferay/frontend/css/rtl/servlet/internal/RTLServlet.java#L122) which will serve a different `main_rtl.css` file when...
> Wouldn't that require us to stop AMD'zing the things? I don't think that's on the table right now, we'll still be wrapping modules in an AMD wrapper, so things...
> we made ourselves this same question 5 years ago, but it was then HTTP/2 what we thought internet would be using instead And it kind of is, isn't it?...
> Even if 5 years from now, it's HTTP3 and it's just downloaded by module, I still see that the use of minification and the maybe single bundle will still...