gnome-runcat icon indicating copy to clipboard operation
gnome-runcat copied to clipboard

Published 20 hours ago • verified publisher icon win0err

Feature/animated-sleeping

Open exincore opened this issue 2 years ago • 1 comments

Animated Sleeping

What?
  • The cat has a sleeping animation now
  • Varying number of sprites can be used in animations without needing to modify code
Why?
  • It is adorable
  • They need a nice nap after running
  • Greater support for different animation sets
How?
  • iconProvider.js looks for and loads sprites into arrays based on their name like running-0 or sleeping-3 etc.
  • iconProvider.js has a rudimentary state machine for different sprite sets (looking to implement feature/different-runners)
  • prefs.js et al. has a toggle button for reverting back to non-animated sleeping
  • Brand new sleeping sprites based on the original my-sleeping-symbolic.svg (contains cute snoozing)

my-sleeping-3-symbolic

exincore avatar Mar 11 '22 21:03 exincore

Hello, @EXINCORE!

Thanks for the PR! I need some time to review the PR.

win0err avatar Mar 14 '22 16:03 win0err

Please, fix conflicts and I will merge the PR

win0err avatar Oct 03 '22 17:10 win0err

Closed by mistake, reopening...

win0err avatar Oct 05 '22 00:10 win0err

Goodness, this will take a while to merge/rebase

exincore avatar Oct 05 '22 01:10 exincore

@win0err I will clean up the idle sprites, but other than that, this feature is ready for re-review. Note that the animation state machine previously implemented in this feature is now removed.

exincore avatar Oct 26 '22 00:10 exincore

Addition of RunnerPacks and RunnerStates constants moves hardcoded values of 'cat', 'idle', 'active' out of the way, and also makes future expansion to other runner states like walking #29 or other runner packs #23 easier.

exincore avatar Oct 26 '22 18:10 exincore

LGTM. Great work, thank you!

win0err avatar Oct 29 '22 21:10 win0err