William Velzeboer

Results 27 comments of William Velzeboer

@ImJohnMDaniel It is kinda similar in what is tries to do, except this design is more on a higher level. AT4DX tries to wrap around some of the interface structure...

> Also, can you elaborate further on why the AT4DX Application class implementation confuses developers? I think its mainly the different levels of abstraction. AT4DX is basically introducing a complete...

> @wimvelzeboer I'm going to take a look at this, but for starters, could you please address the conflicts as you see fit respecting other changes to 'master'. Yes, it...

@stohn777 I saw that there was a lot of overlap with other changes that were already accepted. So, I did some refactoring of those. Now this PR mainly includes the...

> I'm not persuaded with the need for `Application.Selector.setMock(SObjectType, fflib_ISObjectSelector)`. What is the benefit for adding a mock thing that hasn't been properly mocked, other than saving 3 lines of...

@cropredyHelix @afawcett I think we can close this issue as this is implemented, right?

It would be nice to have one commit reformatting the whole source of the repo into a single formatting. Now I sometimes struggle with which styling I need to apply.

Hi @PseudoDarwinist One thing I immediately notice is that you are using a query inside an iteration, therefore you have a high risk of hitting limits. But to answer your...

@PseudoDarwinist Yeah, that is the process. You batchable will look something like: ``` public with sharing class MyBatchableClass implements Database.Batchable { public Database.QueryLocator start(Database.BatchableContext batchContext) { return EventLogsSelector.querylocatorBySomeCondition(); } public...

@PseudoDarwinist You are completely right, if you are never going to change the code again. The goal should not be to write small pieces of code and deliver them fast....