deb-get
deb-get copied to clipboard
added Vagrant
re-based in a different branch based on my previous PR: https://github.com/wimpysworld/deb-get/pull/514
You don't need to keep closing PRs and opening new ones every time someone requests changes. You can just do the requested changes and the PR will update itself. If your work needs more time to be done, you can mark the PR as a draft, and mark it as ready for review when you are done.
You don't need to keep closing PRs and opening new ones every time someone requests changes. You can just do the requested changes and the PR will update itself. If your work needs more time to be done, you can mark the PR as a draft, and mark it as ready for review when you are done.
I understand and you are right. Its just that I was not that familiar with Github, PRs and doing the requested rebase, that I did not get things right on the first attempt. For example I initially forgot to place the Vagrant PR in a separate branch.
I have in the meantime figured it out and was successful with the merge of Smartgit and I think I got the rebase correct with Packer and Vagrant.
No problem, we are all learning.