deb-get icon indicating copy to clipboard operation
deb-get copied to clipboard

added Vagrant

Open chriswayg opened this issue 2 years ago • 3 comments

re-based in a different branch based on my previous PR: https://github.com/wimpysworld/deb-get/pull/514

chriswayg avatar Sep 20 '22 09:09 chriswayg

You don't need to keep closing PRs and opening new ones every time someone requests changes. You can just do the requested changes and the PR will update itself. If your work needs more time to be done, you can mark the PR as a draft, and mark it as ready for review when you are done.

natanjunges avatar Sep 20 '22 14:09 natanjunges

You don't need to keep closing PRs and opening new ones every time someone requests changes. You can just do the requested changes and the PR will update itself. If your work needs more time to be done, you can mark the PR as a draft, and mark it as ready for review when you are done.

I understand and you are right. Its just that I was not that familiar with Github, PRs and doing the requested rebase, that I did not get things right on the first attempt. For example I initially forgot to place the Vagrant PR in a separate branch.

I have in the meantime figured it out and was successful with the merge of Smartgit and I think I got the rebase correct with Packer and Vagrant.

chriswayg avatar Sep 21 '22 13:09 chriswayg

No problem, we are all learning.

natanjunges avatar Sep 21 '22 14:09 natanjunges