Wim Jeantine-Glenn

Results 125 comments of Wim Jeantine-Glenn

Union operator support landed in 2.0.4 - can this issue be resolved? I wonder if the fact that specifying headers _replaces_ the pool manager headers ought to be documented, along...

I am [using anytree's `NodeMixin` class](https://github.com/wimglenn/johnnydep/blob/95fd1e0fd26d9fbea64a5d37229c536514f7457e/johnnydep/lib.py#L40) to render dependency trees in [`johnnydep`](https://github.com/wimglenn/johnnydep). Here is an example of johnnydep rendering the dep tree for the `catcli` project mentioned above: ``` $...

hmm, I may have broken it by deleting a merged branch at [pook](https://github.com/h2non/pook/pull/87) while the branch is still mentioned in [test requirements](https://github.com/wimglenn/advent-of-code-data/blob/c94c84491a7a94f399bd5bc32da4a1a65c81c175/tests/requirements.txt#L3)

Oh, I see, the wrong merge _fork_ was chosen in https://github.com/wimglenn/advent-of-code-data/commit/9fc0e298050af3fa2d7a1957ab204f019edea295 - that feature branch did not merge into `pook @ git+https://github.com/wimglenn/pook` it merged into `pook @ git+https://github.com/h2non/pook` (fixing with...

Thank you for the in-depth review, @mjpieters, a lot of good suggestions here!

@cj81499 Have you lost interest in this PR? There are many conflicts now, but if it's alright with you I'll likely use some of the ideas from the PR -...

Hmm, interesting. I wanted for `puzzle.examples` to just reuse caches and not actually have to hit the server. But this is a convincing reason why we should check the server...

I think this is because the string ["gi" is in the default ignores list](https://github.com/spulec/freezegun/blob/12e54da20e581a05fe64b7f5be16f764ff1dfab2/freezegun/config.py#L15) and the check in the ignore lists is pretty dumb, using [`str.startswith`](https://github.com/spulec/freezegun/blob/12e54da20e581a05fe64b7f5be16f764ff1dfab2/freezegun/api.py#L162). Probably any module name...

https://github.com/conda/conda/blob/4.12.0/conda_env/env.py#L86 :laughing: