Brandon Wilson

Results 99 comments of Brandon Wilson

Ugh... :upside_down_face: https://github.com/interledger/rafiki/blob/889807585763faaf4fc68d9a5d49140776d12501/.github/workflows/docker-auth.yml#L13 https://github.com/interledger/rafiki/blob/889807585763faaf4fc68d9a5d49140776d12501/.github/workflows/docker-backend.yml#L13

It seems like this would resemble the call to the account provider that happens during quote creation which is distinct from webhook events: https://github.com/interledger/rafiki/blob/main/packages/backend/src/config/app.ts#L89-L93 https://github.com/interledger/rafiki/blob/main/packages/backend/src/open_payments/quote/service.ts#L262 https://github.com/interledger/rafiki/blob/main/docs/transaction-api.md#quote I've actually been considering...

>RS Account provider interaction isn't defined in Open Payments. yet: - https://github.com/interledger/rafiki/issues/626#issue-1381270487

1. >it seems that I would _not_ reuse the `/webhooks` route? Correct, if we want to follow the quote creation model, in which the backend currently sends a "synchronous" request...

> 3. Also confirmed by no handlers on the AP side: It should be handling `incoming_payment.expired`. I just opened: - https://github.com/interledger/rafiki/issues/659

>for business rules (account closed, not setup etc.), the account provider may want to decide not to accept that. At first, I was going to suggest that the Account Provider...

:thinking: If we did want to support send only / receive only payment pointers in Rafiki, I'm wondering if that should be reflected in Open Payments (as in, `GET` or...

I'm guessing the concern there would be that (without changing the Open Payments spec) the incoming payment could receive funds between creation and the account provider voiding the incoming payment....

>Seems like a lot of machinery to get moving if the incoming payment may still be rejected. fwiw the connector is already checking incoming payment state https://github.com/interledger/rafiki/blob/f17fdb9981d57d6199062a94ef032d47339b5459/packages/backend/src/connector/core/middleware/account.ts#L49-L57 >2 - is...

Should Open Payments list endpoint query parameters then support `after`/`before` instead of just `cursor`? https://github.com/interledger/rafiki/blob/3d30ce755b4218a777ec77f408be5d15dfa0e687/packages/backend/src/shared/pagination.ts#L9-L20