George Wilson

Results 149 comments of George Wilson

https://github.com/joomla/jissues/blob/master/src/App/Tracker/Controller/Hooks/ReceivePullsHook.php#L63 Looks like we don't

We’ve been storing this data for a while https://github.com/joomla/jissues/pull/982 purely a matter to find a nice way to render it in the UI

Glad to be resident bug finder expert :D

There was a fix merged into 4.2 for this for cli apps using the joomla console. This PR once merged would make some of that functionality available for CLI Apps...

It depends on what you're doing. In some cases you might still be outputting urls or building URLs. In this case the CLI will need such a property. I agree...

https://github.com/wilsonge/joomla-cms/tree/com-router-legacy-rule This rule will parse legacy URLs with the new structure (however it does not validate intermediate segments - this means that `/getting-started/19-sample-data-articles/joomla/22-getting-started.html` parses, but so does `/getting-started/19-sample-data-articles/lalalalalalalal/joomla/22-getting-started.html` which from...

It's cleaner but you can't do it as a temporary measure and keep the interface

https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/component/router/interface.php As in you'd need to break this interface. Which would mean extensions couldn't have an implementation that supports J3 and J4 at the same time

Ahh I didn't think you could. But we're doing that in JTable so I'm wrong. That could work