php-version
php-version copied to clipboard
Add MacPorts support and update README
Thank you! I'm not a Macports user so I'll have to trust that there are no regressions. BTW, you are now a collaborator.
If you feel this is ready to be merged, let me know.
Thanks again!
@wilmoore I'm glad you appreciated my PR, thank you!
Re testing the script after my updates, this is what I haven't tested:
- ZSH support: I don't use that shell even on my Linux boxes
- Homebrew support: as (you know) I'm a MacPorts user ;)
- Custom built PHP: lack of time
I can try the third one in the next days, but the first two are too demanding for my limited time.. If you already have homebrew installed, and/or a ZSH shell at hand, you could give it a try by cloning this PR on your box.
But I'm pretty confident there shouldn't be any issue, as I haven't touched the rest of the script. At setup time, it checks for MacPorts presence only as a fallback for every other method (so they have the precedence over macports). So for non-macports users there shouldn't be any difference in behavior. If someone has both MacPorts php ports installed, AND custom built versions for example, when listing versions they are printed both, but at version selection the custom builds take the precedence.
Paolo
Yes, I definitely appreciate the time taken with this PR. I believe we can cover the testing together if I take on 1 & 2 to make sure there are no regressions with brew
and zsh
.
It might take me some time to get to it, but we'll keep this open until we've got all the testing covered.
Hi @pfurini - are you still looking to maintain this? If not, no worries, but I'll likely close this soon if you aren't going to maintain it.