ember-3d icon indicating copy to clipboard operation
ember-3d copied to clipboard

Published 20 hours ago • verified publisher icon willviles

Ember 2/3 incompatibilities

Open toovy opened this issue 6 years ago • 1 comments

Hi, I've tried this addon and it looks very promising. There is at least the container _lookupFactory method used that is not supported any more in the ember API from ~2.17. onwards (https://www.emberjs.com/deprecations/v2.x/). Using v2.14.1 the example runs smoothly. I've tried to update _lookupFactory to factoryFor, but there also seem to be other changes, line 94 let instance = factoryRegistration.export.create({ fails as export is not available on a value. Maybe you could consider fixing it or at least adding a warning to the readme. Thanks, Regards, Tobias

toovy avatar May 17 '18 04:05 toovy

Hi @willviles I also think this package is promising. Hope you can make the time to fix this issue.

Thanks!

svparijs avatar Jun 21 '18 21:06 svparijs