Will
Will
Relevant code: `scripts/daily_challenges/migrate_daily_challenge_from_staging.coffee` Challenges were indeed in S3, and we don't appear to have access to them in the repo.
Definitely! I'll diff each of these one at a time and see what we can do.
I wrote a Python script to diff these automatically: ```python3 from typing import Dict, List # Identifies CoffeeScript functions through signature and indentation. def find_functions(filename: str) -> Dict[str, List[str]]: start_index...
Another challenge is the reliance on global vars, specifically these two: - `io` object: https://github.com/open-duelyst/duelyst/blob/fa4184f/server/single_player.coffee#L73 - `games` object: https://github.com/open-duelyst/duelyst/blob/fa4184f/server/single_player.coffee#L95 Functions accessing these (nearly all of the above) would need to...
This appears to also result in disappearing history icons.
Relevant code: https://github.com/open-duelyst/duelyst/blob/63cc664/app/view/layers/game/BattleMap.js#L232L259
Each replay is 12-20KB plus 5-7KB of mouse events. Assuming 32KB per replay, we can retain about 30,000 replays with 1GB of storage (which is billed at $0.023 per month...
We're currently adding 1.4 MB/week of replays, or 72.8 MB/year. This is super low priority to prune.
It also looks like `test/integration/misc` can be moved to `test/unit`, since they have no dependencies to integrate with.
I believe this is part of why some integration tests hang: https://github.com/redis/node-redis/tree/v.2.8.0#clientunref