imageproxy icon indicating copy to clipboard operation
imageproxy copied to clipboard

Add support for UNIX domain socket

Open albb0920 opened this issue 4 years ago • 3 comments

This PR adds UNIX domain socket support for the addr option.

I want this as I run all my services behind nginx with unix domain socket. I suppose there are more reasons someone would want to run imageproxy without listening to a TCP port.

I never wrote any Go before this PR, I hope I haven't done anything stupid...

albb0920 avatar Dec 16 '20 04:12 albb0920

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Dec 16 '20 04:12 google-cla[bot]

Codecov Report

Merging #255 (bbb9aca) into main (c08b3c5) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   87.27%   87.27%           
=======================================
  Files           6        6           
  Lines         503      503           
=======================================
  Hits          439      439           
  Misses         36       36           
  Partials       28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c08b3c5...bbb9aca. Read the comment docs.

codecov[bot] avatar Dec 16 '20 04:12 codecov[bot]

@googlebot I signed it!

albb0920 avatar Dec 16 '20 04:12 albb0920