Will Norris

Results 223 comments of Will Norris

> Would you be open to me creating another PR to move the remaining file types into using that approach? Yeah, that was always the intent. Most (all?) of the...

addlicense already handles cmakelists.txt files, or at least it's supposed to: https://github.com/google/addlicense/blob/master/main.go#L311-L314 Does that not work? We certainly wouldn't want to add headers to *all* .txt files, which is why...

What version of go are you using? addlicense requires go1.16, which is when the `io/fs` package was added.

My guess is that your shell is interpreting the "**" before it gets passed to addlicense. What happens if you put it in quotes? ``` $ podman run --rm -v...

Given GitHub's [blog post yesterday](https://github.blog/2021-12-06-safeguard-container-signing-capability-actions/), I tried using the purely Actions based cosign workflow [on a personal project](https://github.com/willnorris/imageproxy/commit/8fd838a5cc8e583cad024ff2dbe9e4281e4a08ca) of mine, and it worked really well. I wonder if we just...

ugh, I really hate how GitHub shows comments sometimes. I actually missed [your reply here](https://github.com/google/addlicense/pull/101#issuecomment-989601239). *sigh* So yeah, I think we should add signing support without goreleaser (at least for...

interesting... I hadn't realized that goreleaser could build docker images as well. I have somewhat mixed feelings though, since if I'm reading [these docs](https://goreleaser.com/customization/docker/) correctly, it requires changing the Dockerfile...

Sounds good. I've gone ahead and assigned this to you to start implementing when you're ready.

I suspect the embedded source information coming in go1.18 should make this pretty simple to do: https://utcc.utoronto.ca/~cks/space/blog/programming/GoVersionOfYourSource

Hey, thanks for the contribution! I worry a bit about adding complexity to support a practice that (in my opinion) should probably be avoided anyway. I fully recognize that engineers...