Will Miles

Results 88 comments of Will Miles

> it does feel wrong, but you cannot copy data that just is not there. like if source is mirrored, target cannot be 'unmirrored' without re-calculating the FX. 'reverse' is...

> I tried using .length() instead of virtual and confirmed the loop went over the full index range but if mirror of source is active, it sill only gets half...

I think a lot of the challenge here comes from some of the corner cases. If I have a segment 1 set as1x8, with mirror enabled, I get virtualLength() ==...

> I thought about this on my way to work and realized that if a getRenderedPixelXY() function is implemented, there is no need to copy the source settings (except maybe...

Apparently I don't do enough with 2D. ;) Possibly the offset field is carrying some historical value, as it's not used in the standard 2D calculations. I can think of...

> when using spacing, 'in between' pixels are not always set to black (may be an underlying bug/feature as that also happens in the source segment if spacing is enabled...

Following on by that: I intentionally omitted source grouping and spacing in the getRenderedPixel() sketch. Grouping could perhaps be included, but spacing doesn't make sense -- the pixels skipped over...

> I have it mostly done now (if there are no objections to latest changes). What remains though: where should the `uint32_t getRenderedPixelXY()` be put? I think it should go...