ngx-skeleton-loader icon indicating copy to clipboard operation
ngx-skeleton-loader copied to clipboard

Published 20 hours ago • verified publisher icon willmendesneto

Support angular 14

Open trentprynn opened this issue 2 years ago • 2 comments

I'm submitting a ...

  • [ ] bug report => search github for a similar issue or PR before submitting
  • [x] feature request

Current behavior

only angular@13 is supported

Expected behavior

angular@14 is supported

trentprynn avatar Jul 19 '22 21:07 trentprynn

Please add support for angular v14.x

BruneXX avatar Jul 25 '22 15:07 BruneXX

@BruneXX @trentprynn for now you can just provide a theme.

E.g.: NgxSkeletonLoaderModule.forRoot({ theme: { 'background-color': '#ff0000', opacity: '0.9' } })

Looks like v14 of Angular isn't picking it up by default

HelloooJoe avatar Sep 01 '22 00:09 HelloooJoe

Hey folks, thanks for raising this issue!

Could you add more details about the issue itself, please? The Stackblitz examples are running using Angular v14, so not sure what this issue is about.

I'll wait for your reply on this issue for few days to get more details about it

willmendesneto avatar Oct 17 '22 11:10 willmendesneto

Sorry, I think I misunderstood how the library src was setup when I opened this issue. I checked the package.json in the root of this project and saw angular@13 dependencies but now realize that’s just for testing+development of the actual library. I am not using this on an angular14 project yet so I cannot confirm experience but feel free to close if angular14 is supported 👍🏼

trentprynn avatar Oct 17 '22 12:10 trentprynn

All good, @trentprynn , nothing to worry about! Thanks for clarifying your point!

I'm closing this issue for now, but please feel free to reopen if you feel it's an issue!

willmendesneto avatar Oct 17 '22 12:10 willmendesneto