body-scroll-lock icon indicating copy to clipboard operation
body-scroll-lock copied to clipboard

Declaration file?

Open bpgusar1 opened this issue 5 years ago • 4 comments

Declaration file?

bpgusar1 avatar Oct 05 '18 22:10 bpgusar1

Hey - sounds good - I'm not the most well versed with typescript, so it would take time for me. I'd be happy to review a PR for this though.

willmcpo avatar Oct 21 '18 11:10 willmcpo

For now just use this declaration file. https://github.com/willmcpo/body-scroll-lock/issues/19#issuecomment-394142303

rohmanhm avatar Nov 27 '18 02:11 rohmanhm

Can this just be merged into the repo? In my (admittedly limited) TS experience, that module definition seems to be fine. Would be nice to not have to add a bunch of lines to my TS shims file just for one small package in my app.

vincerubinetti avatar Nov 15 '21 19:11 vincerubinetti

Ah nevermind, it seems like the types are available in this @types/body-scroll-lock package. In that case this issue can probably be closed.

vincerubinetti avatar Nov 15 '21 19:11 vincerubinetti