body-scroll-lock icon indicating copy to clipboard operation
body-scroll-lock copied to clipboard

Published 20 hours ago • verified publisher icon willmcpo

Support scrolling on both axes (iOS)

Open xanido opened this issue 5 years ago • 9 comments

Currently, enabling bodyScrollLock disables scrolling on anything but the targetElement. However, on iOS, it also locks scrolling to the Y axis, preventing horizontal scrolling on the targetElement.

This PR allows scrolling on either axis on the targetElement.

xanido avatar Sep 18 '19 23:09 xanido

@willmcpo Hello, how does it look with this PR? Will it be released? I would like to use horizontal scrolling. Thanks for the answer.

kubmir avatar Nov 06 '19 11:11 kubmir

@willmcpo please help 🙏

Aarbel avatar Mar 25 '20 07:03 Aarbel

@xanido the horizontal scroll seems to still be frozen if the target can only scroll horizontally.

Have you tested this case ?

Aarbel avatar Mar 25 '20 08:03 Aarbel

Moreover @xanido looks like @willmcpo works in Qantas company in Sydney, so if you want to target him directly to update this repo, you're very close

Aarbel avatar Mar 25 '20 08:03 Aarbel

Hi all, will look into this PR soon

willmcpo avatar Mar 25 '20 12:03 willmcpo

Thanks a lot @willmcpo, sorry again for the multiple pings

Aarbel avatar Mar 25 '20 12:03 Aarbel

@xanido the horizontal scroll seems to still be frozen if the target can only scroll horizontally.

Have you tested this case ?

@willmcpo i think you should also check this

Aarbel avatar Mar 25 '20 12:03 Aarbel

Hey people! is this PR going to be merged soon? I really need this so maybe I need to implement it by myself it it's not going to be merged. Thank you!

drosi94 avatar Aug 17 '21 12:08 drosi94

@xanido the horizontal scroll seems to still be frozen if the target can only scroll horizontally. Have you tested this case ?

@willmcpo i think you should also check this

is this still an issue?

willmcpo avatar Aug 17 '21 13:08 willmcpo