Will McGugan comments

Results 445 comments of


Will McGugan

[REQUEST] Allow console.status(transient=False) to keep it in the console

Not convinced we really need this. You can always print something after the spinner has disappeared.

Detect Databricks as Jupyter environment

Bear with me. Will review PRs within a week or two.

[REQUEST] PEP657 error code ranges in tracebacks

I'd love to implement this. Not certain how to render it yet. Rich shows a few lines before and after the highlighted line, and I wouldn't want to break that...

[REQUEST] PEP657 error code ranges in tracebacks

We have the ability to highlight additional ranges within Syntax now. So this might be a good point to tackle this.

[REQUEST] reprint ommited log times occasionally when number of items in between is too high

Seems reasonable. I might also make the repeated time a dimmer color, so the regular color indicates the start of the minute. Not sure when I'll get to this. If...

[REQUEST] reprint ommited log times occasionally when number of items in between is too high

Not that I know of. You are welcome to give it a shot.

Add the `log_omit_repeated_times` option to `Console`

The constructor already has a large argument list. I'd prefer not to add to it without good reason. What is your use case? Why do you not want identical times...

[REQUEST] Ability to suppress the length of local variables or completely filter them in Rich tracebacks.

How about? `locals_suppress=` `locals_max_length=

Add crosshairs feature

That seems a very good way of expressing the test expectations. It's nice to be able to visually compare. I think, yes the crosshairs should have trailing whitespace. BTW, sorry...

Add crosshairs feature

It's fine not to use `options`. Not all renderables require it. Re testing the ANSI codes. You could test at a slightly higher level. Perhaps test the Segment objects have...