everett icon indicating copy to clipboard operation
everett copied to clipboard

Support _ as the first character in environment variables

Open paul-english opened this issue 1 year ago • 4 comments

This updates the validation regex to allow keys in an env file to start with an underscore.

I just noticed this in conflict with an env var _TYPER_STANDARD_TRACEBACK. This SO post seems to have a pretty valid answer sourcing this document about this https://pubs.opengroup.org/onlinepubs/000095399/basedefs/xbd_chap08.html

paul-english avatar Oct 03 '23 20:10 paul-english

This looks good. Can you please add a test for it? If you can't, I'll get to it in the next month or so. Thank you!

willkg avatar Oct 03 '23 23:10 willkg

Also, it's helpful when the commits have useful summaries. For example, this one would probably be summarized as "Support _ as the first character in environment variables". Can you fix that as well?

willkg avatar Oct 03 '23 23:10 willkg

Sure, I'll double check it and see where to add a test. This edit was from the GH interface, thus the brevity.

paul-english avatar Oct 04 '23 00:10 paul-english

I find the GitHub interface is great for docs fixes, but harder for code fixes where multiple files need to be changed. In that case, I tend to write up an issue instead. If you want, convert this to an issue and I can work through it when I get to it.

willkg avatar Oct 04 '23 14:10 willkg