Willi Rath
Willi Rath
> would it make sense to reuse scikit-learn's KDTree instead of Scipy's cKDTree? Yes, definitely! > It would be interesting to test/benchmark the ball tree + haversine approach versus the...
Re fixed resolution Typical NEMO grids vary in resolution. The example data from the global (nominal 0.5deg) climate model looks like this (shown is `(e1t**2 + e2t**2)**0.5`):  That's a...
@benbovy This is not ready yet and mostly meant for discussing if and how we'd expose indexers. But feel free to have a look and leave comments as soon as...
I'll reduce this to just providing a query method for now. Passing arbitrary kwargs adds a lot of complexity because we loose an easy way of knowing about the structure...
Do as you like. I can easily reopen this PR once it's moved.
Doc build fails with unrelated ["Command killed due to excessive memory consumption"](https://readthedocs.org/projects/xoak/builds/14371608/). The rest is (_finally_) good for a review. I've decided to skip the more elaborate examples for now.
I think leaving `.xoak.sel()` unchanged and as close to the standard xarray `.sel()` API as possible is what we should do. The proposal to have `.query()` returning, both, distances and...
Just watched it. Here’s my immediate thoughts: - The horizontal wipes are almost ok. Just feel a little fast. (On a Macbook 13”, I’d probably like them best with doubled...
Counting pods from the list of pods is not what we want. I'll switch to `len()` of the list of workers instead. Or is there any public API call for:...
Thanks @guillaumeeb for this review! I just committed a more verbose version that now (briefly) outlines the method and has more details on why it matters that we can scale...