Willie Yao

[release-1.30] Add flag to enable fast delete of failed VMSS

1

#### What type of PR is this? /kind cleanup #### What this PR does / why we need it: "Refactor" as a part of fork-upstream realignment. Fork introduces an environment...

[release-1.28] Add flag to enable fast delete of failed VMSS

1

#### What type of PR is this? /kind cleanup #### What this PR does / why we need it: "Refactor" as a part of fork-upstream realignment. Fork introduces an environment...

[release-1.29] Add flag to enable fast delete of failed VMSS

6

#### What type of PR is this? /kind cleanup #### What this PR does / why we need it: "Refactor" as a part of fork-upstream realignment. Fork introduces an environment...

Generate API version upgrade test templates with kustomize instead of hard-coding them

2

/kind cleanup **What needs cleanup:** Currently, the API version upgrade test templates [(example)](https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/12bba901949922c3768b089eab9ff3e116a87309/test/e2e/data/infrastructure-azure/v1.14.5/cluster-template-prow.yaml) are not generated and are instead updated manually. This can introduce lots of room for error whenever...

WIP: Update docs on updating clusterctl API version upgrade tests

2

**What type of PR is this?** /kind documentation **What this PR does / why we need it**: This PR updates documentation on how to update the clusterctl API version upgrade...

Add unit tests for azure/converters/rules.go

9

/kind cleanup **Describe the solution you'd like** Add unit tests for the [`azure/converters/rules.go`](https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/azure/converters/rules.go) file, similar to other tests in the converters package. The goal is to reach at least 80%...

Add missing test coverage for azuremanagedcontrolplane_webhook.go

6

/kind cleanup **Describe the solution you'd like****Describe the solution you'd like** Currently, `azuremanagedcontrolplane_webhook.go` is missing unit tests in the following areas: - [validateManagedClusterNetwork()](https://app.codecov.io/github/kubernetes-sigs/cluster-api-provider-azure/blob/main/api/v1beta1/azuremanagedcontrolplane_webhook.go#L372) requires a new unit test function: -...

Add missing test coverage for azuremachine_validation.go

3

/kind cleanup **Describe the solution you'd like** Currently, azuremachine_validation.go is missing unit tests in the following areas: - [ValidateDataDisks](https://app.codecov.io/github/kubernetes-sigs/cluster-api-provider-azure/blob/main/api/v1beta1/azuremachine_validation.go#L182) and [validateManagedDisksUpdate](https://app.codecov.io/github/kubernetes-sigs/cluster-api-provider-azure/blob/main/api/v1beta1/azuremachine_validation.go#L293) - Add the following test cases to [TestAzureMachine_ValidateDataDisks](https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/api/v1beta1/azuremachine_validation_test.go#L229) -...