William Martin

Results 659 comments of William Martin

Hey @Frederick888, can you provide some more context about the end-to-end workflow here? I believe this relates to triangular workflows where there are 2 remotes, one configured for push and...

Ah, perhaps what I'm missing is that when we create the local branch it needs to be checked out from the upstream? Deleting the old branch: ``` ➜ git branch...

I think the issue here is that when the branch starting point doesn't contain a remote, then the `config` doesn't contain enough information about the upstream repo, which is where...

@Frederick888, I started extracting issues to describe each of these enhancements in detail e.g. https://github.com/cli/cli/issues/9363 I'm having trouble understanding the second commit in this series. It seems like the first...

Ah right, I see. Because `simple` is the default, we can just assume that the name of the remote branch is the same as the local branch. I'm trying to...

Under what circumstances could there be a remote branch that has a PR open from it, but `@{push}` doesn't resolve when `push.default = current`? The only case I can imagine...

Apart from my question above I believe I've captured the value of these changes in the following issues: * https://github.com/cli/cli/issues/9363 * https://github.com/cli/cli/issues/9364 * https://github.com/cli/cli/issues/9365 * https://github.com/cli/cli/issues/9374

Yeh right, so when `push.default = current` the second commit is only relevant if the remote branch hasn't been fetched. I'm just ensuring I understand the scenarios at play here....

> Or the user hasn't pushed. If the user hasn't pushed then there can't be a PR open to `view` or `status`, right? This is what I was describing above....

Got it! Nice one. Ok, just for your information I am now on vacation, however, I just wanted to finish all the open parts of this discussion. I'd hoped to...