mongo-mock icon indicating copy to clipboard operation
mongo-mock copied to clipboard

Published 20 hours ago • verified publisher icon williamkapke

prevent the module from throwing uncatchable errors

Open kjarmicki opened this issue 4 years ago • 2 comments

Hello,

There are situations when this module throws errors from inside of setTimeout callback that are impossible to catch from the outside and cause a process exit (unless caught with global uncaughtException handler, but I don't want that :wink:). This is the case with any uncaught error thrown inside of a callback scheduled with asyncish.

This PR fixes that. I've chosen a method that seemed least invasive to the codebase.

kjarmicki avatar Dec 20 '20 12:12 kjarmicki

Thanks for the approve @shaunburdick :slightly_smiling_face: Is there a chance to merge and release this patch?

kjarmicki avatar Dec 28 '20 16:12 kjarmicki

Hey @shaunburdick can we please merge and release this patch? :pray:

kjarmicki avatar Mar 26 '21 13:03 kjarmicki