ipp icon indicating copy to clipboard operation
ipp copied to clipboard

debugger statement in the parser module causes application hang

Open letalumil opened this issue 9 years ago • 3 comments

I use nodemon in the debug mode during the development time and attach a debugger only when I really intended to dig into something. Today when I worked with a new printer I encountered a problem that my application hangs. After a quick investigation I found that the problem is in this line: https://github.com/williamkapke/ipp/blob/8ce50cc37c372be544a2f8df22b3dd82a6f5cb1f/lib/parser.js#L132

Since I run my code in the debug mode, execution pauses on this line, but I have no debugger attached, so I'm not notified about the pause and has no way to do something with it.

There is one more line that can cause the same problem: https://github.com/williamkapke/ipp/blob/8ce50cc37c372be544a2f8df22b3dd82a6f5cb1f/lib/serializer.js#L197

@williamkapke do you think it's OK to remove the statement? If so, I'll create a PR.

letalumil avatar Dec 08 '16 11:12 letalumil

Yes- you can certainly remove them!

williamkapke avatar Dec 09 '16 01:12 williamkapke

Wouldn't it be better you remove it so that we are not forced to have a fork? I known that this is a VERY old issue but it's still in.

Thanks

Jochen

ghost avatar May 22 '18 10:05 ghost

I'd be great if #83 would be merged and a new version of ipp released!

fpauser avatar Jan 21 '20 12:01 fpauser