William Desportes
William Desportes
Hello @sgiehl What is the best path for me to get this one merged ?
Weird CI failures, new commits broke something or is it my diff ?
> Not sure, but probably the PHPUnit workflow should be updated too so it can use `composer update`? Now it tries to run PHPUnit 11 on PHP 7.2. > >...
I dropped the last commit, it should help
I did some ajustements as I am quite sure the ignore should not have been used for all versions and this way.
> Run local php vendor/bin/phpcbf for fix phpcs Unrelated, see CI log > PHP Parse error: syntax error, unexpected '|', expecting variable (T_VARIABLE) in /home/runner/work/device-detector/device-detector/vendor/phpunit/phpunit/src/Framework/Assert/Functions.php on line 83 Probably some...
> @williamdes is it possible to update the workflow so it does look like this? Not really (I have no options to change the text), can it be merged as...
Hi @sgiehl Can you check this one please ?
> I don't know how we can prevent this problem from occurring in sql-server though. sql-parser I think it will be worth investigating
Hi @shaedrich Thank you for taking the time to report this issue, I will keep it in mind and will try to fix it. Contributions are very welcome !