git-pretty-pull-request icon indicating copy to clipboard operation
git-pretty-pull-request copied to clipboard

Use the preferred file editor configured in git?

Open foucdeg opened this issue 6 years ago • 4 comments

Something like EDITOR=$(git config --get core.editor)

foucdeg avatar Sep 25 '18 15:09 foucdeg

@williamdclt After reading more on this, it seems that the env variable you used, EDITOR, is a system-wide standard, which git actually uses if you don't specify core.editor. So I guess I could export EDITOR=whatever too.

foucdeg avatar Sep 25 '18 15:09 foucdeg

Yeah I have export EDITOR=vim in my .zshrc :) But using the git editor definitely makes sense, a PR would be welcome

williamdclt avatar Sep 26 '18 09:09 williamdclt

which do you think should take precedence between EDITOR and git config --get core.editor ?

foucdeg avatar Sep 26 '18 12:09 foucdeg

git config --get core.editor, like in git itself

williamdclt avatar Sep 26 '18 13:09 williamdclt