mason.nvim icon indicating copy to clipboard operation
mason.nvim copied to clipboard

[New package]: GLSL language server

Open mokafolio opened this issue 2 years ago • 3 comments

I've searched open & closed issues for similar requests

Yes

Package name

glsl-language-server

Package homepage

https://github.com/svenstaro/glsl-language-server

Languages

glsl

How is this package distributed?

github

mokafolio avatar Nov 04 '22 17:11 mokafolio

Hello! Pull requests are always very welcomed to add new packages. If the distribution of the package is simple, the installation will most likely be so as well. See CONTRIBUTING.md and the API reference for more details! You may also use existing packages as reference.

 🤖 This is an automated comment.    📖 Source code 

williambotman avatar Nov 04 '22 17:11 williambotman

Hi, I'm looking to add the newer and maintained glsl_analyzer to registry as a package (Unfortunately, glsl-language-server by svenstaro is not maintained anymore). I have encountered issues:

  • the mason registry yaml schema provided doesn't allow glsl or anything close to "opengl shading language" as an option,
  • i get a warning of String does not match the pattern of "^pkg:cargo/.+@.+" when filling out the id field

These are only warnings from the schema provided, I don't fully understand if that means I'd have to resolve this before PRing

Thank you!

ghostfish0 avatar Nov 18 '23 17:11 ghostfish0

  • the mason registry yaml schema provided doesn't allow glsl or anything close to "opengl shading language" as an option,

In the case a new language is added it'll have to be added to the schema file schemas/enums/language.json. You'll still encounter a validation error in Neovim because it sources the schema elsewhere (the PR will have to be merged before this schema is updated).

  • i get a warning of String does not match the pattern of "^pkg:cargo/.+@.+" when filling out the id field

It's difficult to say why without an example but most likely it's missing a version specifier.

williamboman avatar Nov 20 '23 12:11 williamboman

@ghostfish0 any progress on this front?

cowboy8625 avatar Jan 19 '24 13:01 cowboy8625