Will Dean comments

Results 623 comments of


                                            Will Dean

Adding introspection to the PyPika query builder

yeah, I think returning strings would not be ideal for general usage. What do you imagine the result would store if it was not the `Table` and `Field` instances? Those...

Problem in Abstract class

Seems like the Message gets LIST_QUERY as an abstract method. i.e. `Message.__abstractmethods__` This provides the same error. Might be related somehow ```python from abc import ABC, abstractmethod class Test(ABC): @abstractmethod...

fix cross join test and add docs

> I don't know why it is like this since I didn't implement this, but as pypika is now this is AFAIK the correct way to do a cross join....

MySQL queries should wrap set operations

Are you trying to recreate that specific example? I'm seeing that ```python from pypika.dialects import MSSQLQuery query = MSSQLQuery.from_("table").select("id").union(MSSQLQuery.from_("another_table").select("id")) query.get_sql() # or str(query) ``` does indeed use the parens ```text...

MySQL queries should wrap set operations

I misread that then. Here in the code, the `wrap_set_operation_queries` is set to False. https://github.com/kayak/pypika/blob/8841520e906970d76c5ed81c7dd5d154f0d5259d/pypika/dialects.py#L90 Would you want to make a PR to change? In the meantime, you might be...

ClickHouse dialect: CREATE TABLE

Would you like to make a PR?

Use correct "insert ignore" syntax for Sqlite.

Would you be able to test the change?

:star: Improve parameterized query support - fixes #793

Thanks for the PR! Will take a deeper look later

:star: Improve parameterized query support - fixes #793

Do you have any thoughts as well? @AzisK

Pass kwargs through to `get_function_sql`

Would you like to make a PR?