Will Dean
Will Dean
Sounds good. The case that I will finish with is the behavior with leading + or - for the implementations that are using lpad
I've added a test case for the leading +. zfill from python does "+1".zfill(3) = "+01". But it seems like the polars eager does something different These are the current...
well pandas and polars don't match 😆
I've adjusted the tests and the implementations to match polars behavior. I have a case for pandas. I'm new to arrow and still working through that implmenetation. Open to pointers!
Thanks for the review. I will add those changes. Do you know how to do the arrow implementation? Arrow test failure ``` def zfill(self, width: int) -> ArrowSeries: length =...
Thanks for the help @dangotbanned !
Ha, seems like the pandas behavior has even changed in the versions that are being tested? Confusing. https://github.com/narwhals-dev/narwhals/actions/runs/15283097790/job/42986670950?pr=2598 The edits you made worked for me locally, but seeing some pyarrow...
It seems to just be the https://github.com/narwhals-dev/narwhals/actions/workflows/extremes.yml workflow now. Which gets caught in the random runs as well: https://github.com/narwhals-dev/narwhals/actions/runs/15283218688/job/42988106594
Thanks for the eyes and work here. Let me look this over and make the edits is there an example of xfail for a specific constructor or do I just...
I have this issue as well. However, it doesn't happen all of the time. How often does it happen for others?