Will Dean comments

Results 623 comments of


                                            Will Dean

Model Diagnostics Tests

For loo, try this https://github.com/pymc-labs/pymc-marketing/discussions/805

Model Diagnostics Tests

Hi @shuvayan Any luck with this?

Is there a way to get the plots for adstock and saturation functions from the inference data object

One thing that you might not want to do is adstock the linspace / arange because the adstock function takes into account previous spends. To the function, this is viewed...

Switch to setuptools-scm / hatch-vcs for version management

Is this part of the release workflow?

`MediaTransformation` and `MediaConfigList` in example notebook

Hi @Ishaanjolly, The `mmm_components` notebook might be a good location for this. That has been a catch all for various building blocks of the MMMs.

`MediaTransformation` and `MediaConfigList` in example notebook

> Cool, can I try to add something then? maybe you could give a review for my PR? Yes, feel free to adjust that notebook and make a PR. Some...

Missing module / class docstrings

Related to #367

Expose optimization of media transformations for alternative priors specification

> This is exactly what I need! Hi @sonriks6 Thanks for the feedback. Are there any other media spend spends that resonate well that might be missing?

Parameter recovery on simulated data - issue with saturation parameter

Hi @jaylin1, I am looking over your code snippet. EDIT: Good tip from @juanitorduz. Give that a try first and see what you can come up with. The scaling is...

Parameter recovery on simulated data - issue with saturation parameter

Hi @jaylin1 Any progress with this?