Will Dean comments

Results 623 comments of


                                            Will Dean

Model Evaluation, Diagnostics and MLFlow Registry

Thanks for making the edit! I will take at the end of the weekend

Model Evaluation, Diagnostics and MLFlow Registry

Press the "Update branch" button when you can @louismagowan

Model Evaluation, Diagnostics and MLFlow Registry

Hi @louismagowan Let me know if you need any support with writing tests. That's something I gladly do 😄

Model Evaluation, Diagnostics and MLFlow Registry

I am having some issue with the `load_model` with `keep_idata` set to `False`. ```python run_id = ... loaded_mmm = load_model(run_id, full_model=True, keep_idata=False) parameter_in_model = "saturation_beta" param = az.extract(loaded_mmm.idata.posterior, var_names=[parameter_in_model]) ```

Model Evaluation, Diagnostics and MLFlow Registry

Can you add an example of loading the model here: https://www.pymc-marketing.io/en/stable/notebooks/mmm/mmm_budget_allocation_example.html#loading-a-pre-trained-model

Model Evaluation, Diagnostics and MLFlow Registry

> Any idea why those tests are failing @wd60622 ? They aren't in the scope of my PR, I don't think 🤔 The tests are with fresh installs of libraries....

Model Evaluation, Diagnostics and MLFlow Registry

> Apologies - I had some work stuff come up, been pretty slammed recently (before my holidays), but will get to this ASAP. I'm travelling this weekend but should have...

Model Evaluation, Diagnostics and MLFlow Registry

Hi @louismagowan Can you resolve the git conflict

Model Evaluation, Diagnostics and MLFlow Registry

Hey @louismagowan, if you need any support, let us know. BTW, I will take a look at #1259 soon and will be working with the same files. Not the end...

Model Evaluation, Diagnostics and MLFlow Registry

I am not too sure. Let me look into it On my end, it says there are no changes. Feel free to start a new PR. We will all then...