William Jones

Results 23 comments of William Jones

I'm not 100% sure. Tagging @afaulconbridge here too!

So this is an interesting proposition - my one concern is that the 14GB would need to be downloaded for this functionality to work. In our use case, for example,...

> Would there be any way to build the resources into the container / image filesystem where snps is being executed? Then, snps could point to that resource directory and...

I have noticed that for AncestryDNA files, the `_assign_par_snps` step can take a substantial amount of time (> 1 minute), because of repeated API requests. I have currently bypassed this...

This seems like a sensible approach 👍 . We have just encountered the issue you describe in #43 ourselves in fact with Sano genotype data files where the X chromosome...

Hi @apriha - were you in the midst of tackling this? This is functionality that will be soon be important for us so I'm considering jumping in on this.

In fact - it is more #43 that is directly relevant for us so I will look to fix that first.

I like that suggestion about keeping the `genotype` column for backward compatibility.

Hi @EmilienDupont - thanks for the response, and interest! It seems that I didn't get a notification of your reply which is why it took so long for me to...

Makes sense! In the meantime, we have converted the dictionary to a list of key, value pairs, which seems to work ok. It would be cleaner to have it as...