docker-crontab icon indicating copy to clipboard operation
docker-crontab copied to clipboard

Published 20 hours ago • verified publisher icon willfarrell

General Fixes

Open SimplicityGuy opened this issue 3 years ago • 4 comments

  • cleanup of script based on shellcheck.net
  • general reformatting
  • updated alpine version
  • addressed issues:
    • top-level script name is not picked up
    • jq parsing errors if some properties are not set

SimplicityGuy avatar Jul 16 '22 18:07 SimplicityGuy

@willfarrell Any update on reviewing these changes?

SimplicityGuy avatar Jul 17 '22 23:07 SimplicityGuy

@willfarrell Would appreciate the review. :)

SimplicityGuy avatar Jul 23 '22 19:07 SimplicityGuy

@SimplicityGuy, looking at the age of other PRs for this repo I think development for it is dead.

RoboMagus avatar Aug 04 '22 06:08 RoboMagus

I agree, @RoboMagus. I've already forked this and am running my own instance. Will maintain it with some additional improvements too. I'll keep this PR open in hope that perhaps it'll be merged someday. I won't publish an official image like @willfarrell did, so folks will need to build their own if they want to use my fork with the fixes. Still need to figure out some logistics on builds and whatnot since I use GitLab for my private Docker repo (better terms for free users). But I'll definitely keep my Github fork alive and up-to-date.

SimplicityGuy avatar Aug 04 '22 19:08 SimplicityGuy