docker-autoheal icon indicating copy to clipboard operation
docker-autoheal copied to clipboard

Update docker-entrypoint

Open olderthantheinternet opened this issue 3 years ago • 7 comments

line 75 using "text":"$text" fails, but if you change it to "content":"$text" it works

olderthantheinternet avatar Oct 07 '21 22:10 olderthantheinternet

Thanks for the PR. Can you share which webhook url you're using? There might be different payloads expected from different providers. Can someone else test and confirm?

willfarrell avatar Oct 08 '21 01:10 willfarrell

I should have included a sample, sorry about that -

https://discord.com/api/webhooks/blahblah

It's your basic hook when creating one from - https://support.discord.com/hc/article_attachments/360101553853/Screen_Shot_2020-12-15_at_4.51.38_PM.png

olderthantheinternet avatar Oct 08 '21 02:10 olderthantheinternet

hmmm, I'm wondering if the key for the text/body/content needs to be a variable itself. That way it can be flexible for even more webhooks.

willfarrell avatar Oct 09 '21 01:10 willfarrell

Just a note that Apprise supports sending notifications to Discord, so this could be covered by using Apprise with my PR #74

See the list of supported services: https://github.com/caronc/apprise/wiki#notification-services

fracai avatar Oct 12 '21 02:10 fracai

I forked autoheal and added the change for discord and added the Apprise PR to play with both sending to discord. I think I like the apprise approach better. It's an additional service however so another point of failure and additional resources.

RXWatcher avatar Oct 12 '21 02:10 RXWatcher

It's an additional service however so another point of failure and additional resources.

That’s a fair concern, though it’s also an additional burden on maintaining however many notification services within autoheal, versus offloading that to a resource with that single goal.

fracai avatar Oct 12 '21 02:10 fracai

@fracai agreed. I would opt for the apprise as its so flexible and can cover any notifications we want.

I was thinking as I set that up that everyone has their niche. The apprise devs passion is clearly notifications of all kinds.

Btw: Your PR is working perfectly for me.

RXWatcher avatar Oct 12 '21 03:10 RXWatcher