Peter Willendrup

Results 263 comments of Peter Willendrup

@mads-bertelsen I am inclined to merge your PR as is and defer a proper GPU'ified solution until later. Will keep this issue open for this reason.

Yup. I am thinking the logic of the full adaptation of the CFLAGS line is: 1. mcrun inserts @COMPILER_NAME@ (default is McStas build-time compiler from mccode_config, but e.g. --openacc or...

@tkittel I believe this was in essence fixed by the introduction of @NCRYSTALFAGS@ in https://github.com/mccode-dev/McCode/pull/1855 ?

Dear @minghuisvn Thank you for reporting your findings. I believe most of the things you observed can be easily rectified: 1. I am certain your observation of a "confused ellipse"...

Dear @minghuisvn, First a little general advice: * Please do not immediately assume that there is a **bug** every time you see a simulation result you don't understand. McXtrace may...

Dear @minghuisvn, You are very welcome and good luck practicing McXtrace. :-) Best, Peter

@minghuisvn did you figure out yourself in the end or do you need more help? :) (Sorry, have been / am very busy elsewhere.)

Hello @minghuisvn, Thanks for reporting! Indeed it seems the component had multiple issues, most importantly: * Wrong sign on calculations in surface-grid points in the DISPLAY section (visualisation only) *...

(@farhi I will look / fix once I am back from vacation, but I believe what was there prior to f9c844207a140d2e12aed13922c216b4a6a94c36 and bc505762c2ee0beda817c74f03eb4b521ec28745 "worked" numerically - but that `tth_sign` **needed**...

An if statement here should likely be shifted from if (repeat_count) -> if (repeat_count>1) Thanks for reporting @ebknudsen