BazingaJsTranslationBundle icon indicating copy to clipboard operation
BazingaJsTranslationBundle copied to clipboard

Published 20 hours ago • verified publisher icon willdurand

configure the dump folder

Open bazo opened this issue 3 years ago • 1 comments

it would be nice if the dump dir could be configured in bundle config and not on command line, so it's less error prone and the same for everyone on the project and ci/cd

btw, the docs say: "By default, it generates files in the public/js/ directory." but in code it's web/js

https://github.com/willdurand/BazingaJsTranslationBundle/blob/master/Command/DumpCommand.php#L89 https://github.com/willdurand/BazingaJsTranslationBundle/blob/master/Dumper/TranslationDumper.php#L122

thanks

bazo avatar Dec 15 '21 13:12 bazo

You are right @bazo, makes sense. web/js is the old folder structure. What do you think if you create a PR fixing this? 😄

monteiro avatar Dec 15 '21 17:12 monteiro