BazingaHateoasBundle icon indicating copy to clipboard operation
BazingaHateoasBundle copied to clipboard

willdurand/Hateoas#325 support for php attributes

Open ixarlie opened this issue 3 years ago • 6 comments

Adds a new service hateoas.configuration.metadata.attribute_driver for the AttributeDriver class (https://github.com/willdurand/Hateoas/pull/326)

Moreover, hateoas.configuration.metadata.attribute_driver and hateoas.configuration.metadata.annotation_driver are combined in a new service hateoas.configuration.metadata.annotation_or_attribute_driver to give the extension feature to both services.

The hateoas.configuration.metadata.attribute_driver will be removed if the PHP version is prior 8.1.0, so the hateoas.configuration.metadata.annotation_or_attribute_driver will have only the annotation driver.

This PR will require a new release version of willdurand/Hateoas

ixarlie avatar Jan 10 '23 22:01 ixarlie

Is anyone handling this PR?

fabianoroberto avatar Jan 03 '24 14:01 fabianoroberto

any new about this PR?

loic425 avatar Apr 25 '24 09:04 loic425

Hello everyone, Any news about this PR ?

I have developed a catalog of micro services that are using this great bundle and I recently migrated all annotations to php8 attributes except hateoas because it is still not available. If it is necessary I can apply any requested changes to this PR, I have 1-2 month availability to contribute.

What do you think @ixarlie @W0rma ?

jeandonaldroselin avatar Jun 24 '24 13:06 jeandonaldroselin

Hi @jeandonaldroselin ,

I am still waiting for the final review by the maintainers.

Nonetheless, I appreciate any suggestions that may improve the code. Same for https://github.com/willdurand/Hateoas/pull/326

Thank you kindly

ixarlie avatar Jun 24 '24 15:06 ixarlie