Will Clark

@hebasto I see that you are working on `symbol-check.py` in https://github.com/bitcoin/bitcoin/pull/25020 I would be curious therefore to know what you thought of my approach to checking for disallowed symbols (to...

> Not sure what is up with CI, but lint says: > > ``` > contrib/devtools/special-instruction-check.py:55: error: "Binary" has no attribute "has_section" [attr-defined] > ``` > > Maybe rebase? mypy...

Ah I see. I rebased an re-ran the lint to see it fail locally, but didn't update my lief version!

It does in fact, appear to need changes: ```sh will@ubuntu in ~/src/bitcoin-18603_si_check on  18603_si_check [$!?] : C v16.0.5-clang : 🐍 3.8.16 $ pip3 install lief==0.13.1 Collecting lief==0.13.1 Using cached...

It seems that although the stubs can be found in https://github.com/lief-project/LIEF/blob/b9a5f970b210dbc115c7aaac10e04623bdc08ef8/api/python/lief/ELF.pyi#L369-L371, they are not present for the `Binary` type https://github.com/lief-project/LIEF/blob/b9a5f970b210dbc115c7aaac10e04623bdc08ef8/api/python/lief/__init__.pyi#L27. It almost looked possible that we could just switch to...

> BTW: along with some capstone magic like https://github.com/bitcoin/bitcoin/pull/29874, and a bare-bones DWARF (or linker map) parser to get function ranges, it would be possible to make a check like...

Is the plan here to review #28574 and try and get that in, if it improves things, or should we remove the warning as proposed here and add a note...

I tried to reproduce using a wallet with ~1k tx located on a spinning disk -- although this time on regtest -- but I found `migratewallet` to be pleasantly fast:...

I was able to reproduce it with wallet version 60000 and 1k keys/tx I also see 30 mins... ```fish ₿ /home/will/src/bitcoin/src/bitcoin-cli -regtest -datadir=/media/will/PEPSI/regtest-v60000 getwalletinfo { "walletname": "", "walletversion": 60000, "format":...

Re the commit message in "Use bitcoin-core verify.py script": I opened a pull https://github.com/bitcoin/bitcoin/pull/28418 to permit exact architecture-platform specifiers and reduce the amount downloaded by the verify.py script. IMO even...