Will Clark
Will Clark
I think an upstream PR may be the best approach here, So I opened https://github.com/becheran/mlc/pull/89
> Not sure if globbing is the right fix. Conceptually, no folder or file should be scanned that is not tracked in git. > > Though, I wonder if there...
> `git ls-files` is also used in `./test/lint/lint-python.py`, for reference. So using `git ls-files -- '*.md'` and passing the full array to mlc may be the best approach for us?...
Might partially address https://github.com/bitcoin/bitcoin/issues/29662
I ran some benchmarks of IBD to block 800,000 vs master for comparison, and got some similar, if slightly less impressive, results with default dbcache. With `-dbcache=16384`: - master@ fdb41e08:...
Thanks @sangaman. Additionally, do you have any estimates on how many rpcs you are making per time to the node?
I think setting this to 1 will give significantly worse performance for most users though? Seems like it would be better to add it to the documentation if anything...
Is this still a problem with v26.0 (or later)?
OK, I think I have pretty much identified the root cause here. Calling [`blockToJSON`](https://github.com/bitcoin/bitcoin/blob/98dd4e712efaa2b77cb168426756879c6405c3f4/src/rest.cpp#L340) on a maximum-sized block allocates 70-80MB on the heap during runtime. There is then an additional...
Discovered another attempt to avoid copies from @maflcko https://github.com/bitcoin/bitcoin/pull/25429 while researching further. Ref my previous test in #30052, I have a branch with some improvements (heavily "insipred" by @martinus 's...