crystal-pg icon indicating copy to clipboard operation
crystal-pg copied to clipboard

`crystal tool format` with Crystal 1.15.0-dev

Open straight-shoota opened this issue 1 year ago • 3 comments

Crystal nightly has a couple new formatter rules enabled: https://github.com/crystal-lang/crystal/pull/14718 The changes are backwards-compatible, so Crystal 1.14.0 won't complain about the new format.

straight-shoota avatar Oct 11 '24 12:10 straight-shoota

CI still fails with formatter issues. I presume that's because the nix flake uses an earlier Crystal version which does not yet accept the new formatter rules. Feel free to merge when it's convenient (e.g. when updating the Crystal version in CI)

straight-shoota avatar Oct 11 '24 12:10 straight-shoota

Yeah I was just looking at that, it looks like the most current release on nixpkgs is still Crystal 1.11.2 :/

will avatar Oct 11 '24 12:10 will

Updated my old 1.12 pr to be 1.14 https://github.com/NixOS/nixpkgs/pull/303173. I tried this time posting on their forum to see if someone will review it this time

will avatar Oct 11 '24 14:10 will