browserosaurus icon indicating copy to clipboard operation
browserosaurus copied to clipboard

Not working with links from Full Screen apps and multiple workspaces/desktops (need to restart app frequently)

Open varunyellina opened this issue 2 years ago β€’ 54 comments

Is there an existing issue for this?

Current Behaviour

I use apps in Full screen mode on macOS Ventura 13.0.1. When Browserosaurus app starts, clicking links in the full-screen apps works. The Browser selection overlay shows up on the full screen app.

After sometime (indeterminate) when I click on a link in a full screen app, the space changes to the Desktop and Browserosaurus selection overlay shows up for a split second and disappears.

https://user-images.githubusercontent.com/1850730/205856408-60466156-5bf5-4a4d-b279-590c3f013cdb.mov

Expected Behaviour

The Browser selection overlay should show on the Full screen app and allow me to tap on a Browser.

Steps To Reproduce

  1. Make an app Full screen
  2. Click on a link

Browserosaurus version

19.3.3

macOS version

13.0.1

CPU Architecture

ARM

Anything else?

No response

varunyellina avatar Dec 06 '22 08:12 varunyellina

Thanks for the bug report. I think this has happened before, some sort of Electron limitation, I can't remember. Anyway, I'll mark it as "help wanted" as I don't fullscreen apps πŸ™‚

will-stone avatar Dec 06 '22 08:12 will-stone

I have had this same issue on and off for a long time, but in the last week or see it seems to have really ramped up how often this occurs. @will-stone do you remember anything about how it happened before to help figure out which direction to go in?

metacurb avatar Dec 09 '22 15:12 metacurb

Sorry, no. There may be some clue in searching the issues but nothing off the top of my head, no.

will-stone avatar Dec 09 '22 17:12 will-stone

I have occasionally noticed this in the rare times I use full screen mode, but if I observe an obvious pattern and have a hunch I'd be happy to discuss it further here and potentially think of a solution or PR

riotrah avatar Dec 11 '22 22:12 riotrah

I do fullscreen apps every day and can say that I've been seeing this issue more and more lately. Perhaps since updating to Ventura. I didn't know this was happenning specifically with fullscreen apps, so I'll try to not fullscreen them and check if I see it again.

cesmend avatar Dec 13 '22 07:12 cesmend

Looks related: https://github.com/electron/electron/issues/36364

will-stone avatar Dec 13 '22 07:12 will-stone

This is occurring for applications that are not in fullscreen mode as well. The only workaround is to quit and re-open browserosaurus.

jishnu7 avatar Dec 15 '22 04:12 jishnu7

@jishnu7 Are you using virtual desktops?

Please note, I do not maintain the code for the underlying framework, Electron. If you'd really like to help, please add reproducible examples to the issue on their tracker: https://github.com/electron/electron/issues/36364 Thank you ☺️

will-stone avatar Dec 15 '22 07:12 will-stone

Hope this issue gets fixed soon. Really wished i knew how to help. ;-)

iurikothe avatar Dec 19 '22 23:12 iurikothe

I did dig deep and found reproducible steps.

  1. Open Google Chrome on Desktop 1.
  2. Open Mail or any other application which has the link that we are going to open, on Desktop 2
  3. Clicking on the link in Desktop 2 will open browser prompt on correct Desktop.
  4. Go to Google Chrome, visit YouTube, play any video and click on full-screen button in the seek bar.
  5. Exit full screen
  6. Go to Desktop 2 and click on the link again. You can see that Browserosaurus is opening in an incorrect desktop and not allowing you to click on the browser list.

jishnu7 avatar Dec 20 '22 16:12 jishnu7

Thanks @jishnu7 Now if you could boil that down to a very simple reproducible example for the Electron project, that would be awesome 😎 I use neither virtual desktops nor full screen apps so this will never be a priority for me πŸ‘

will-stone avatar Dec 20 '22 16:12 will-stone

What do you mean by example for the electron project? If you can share some pointers, I might be able to help on that.

jishnu7 avatar Dec 20 '22 17:12 jishnu7

@jishnu7 Your best bet is probably to use Electron Fiddle to make a reproducible example, you can then publish that and post it as an issue on the Electron repo πŸ™‚ πŸ‘

will-stone avatar Jan 01 '23 07:01 will-stone

This is occurring for applications that are not in fullscreen mode as well. The only workaround is to quit and re-open browserosaurus.

I can confirm this as occurring more and more lately and also with non full-screen apps unfortunately. Same workaround here.

kristiannotari avatar Jan 02 '23 16:01 kristiannotari

Same problem here

MaickelHubner avatar Jan 05 '23 09:01 MaickelHubner

@ will-stone, you could restart the App automatically every 15 minutes (make it a parameter) to solve this (temporarily). What do you think?

MaickelHubner avatar Jan 05 '23 09:01 MaickelHubner

Sorry, that doesn’t sound like a good idea. The best solution is for someone to create a small reproducible example and submit to Electron.

will-stone avatar Jan 05 '23 11:01 will-stone

I see this issue also. or a variant at least. If I have an application like Outlook, with a link in one of the email, the expected behaviour is to click on the link and to get the menu choice of which browser to open the link in.

Having restarted Browsersaurus, that happens.

However, after a period of time (varies) one of two things happens:

  • I click on the link, select the browser I want to open it in but nothing happens and I stay in the current window
  • the menu of browser options stops appearing.

A reboot of Browsersaurus resolves the issue. Until it re-occurs.

To me it feels like there might be an issue with the browser requested being on a different desktop to the application where the ink menu is triggered, so in effect it can't fine the target and fails.

I'm on the latest Mac OS and latest patch. Any assistance in fixing this would be much appreciated as this is a really killer application :-)

metamole avatar Jan 13 '23 14:01 metamole

Any assistance in fixing this would be much appreciated

Indeed! πŸ˜„

Create a reproducible minimal example, and send it to the Electron project.

Please only update the issue if you can provide more information than has already been gleaned above: there will be quite a few people watching this now, and every time a new post is made they will be notified and disappointed it is not progression.

Thanks πŸ™‚

will-stone avatar Jan 13 '23 15:01 will-stone

It seems fixed after upgrade to Ventura 13.2.1... Will see after some time. Will update if issue will appears again

vkravets avatar Feb 24 '23 17:02 vkravets

It seems fixed after upgrade to Ventura 13.2.1... Will see after some time. Will update if issue will appears again

I was still seeing this issue on 13.2.1 but then I realised I was running Browserosaurus 20.0.2 so I just updated to 20.1.0. Will report back if problem persists.

gardamork avatar Feb 27 '23 14:02 gardamork

Just for reference: https://github.com/will-stone/browserosaurus/issues/175. Seems like same issue resolved in the past Anyway, 20.1.0 on Ventura 13.2.1 works fine for me for some time only and then stops. Restart required

kopach avatar Mar 09 '23 10:03 kopach

I'm using multiple desktops daily, so this is critical for me. As a workaround - I've downgraded to https://github.com/will-stone/browserosaurus/releases/tag/v19.3.3 and blocked network access for the app, so it can't auto upgrade - testing.


Update: doesn't work also 😒

kopach avatar Mar 15 '23 14:03 kopach

this is still happening.

macmus82 avatar Apr 08 '23 20:04 macmus82

Alright, I came up with a temporary workaround for this issue. I've created the script that would re-start the app. I've placed it into cron job to run every X minutes, but you can run it manually as well (or run it from Alfred, Mac Shortcuts, etc.) Here is the script:

#!/bin/bash

# If Browserosaurus is not running, exit, no need to re-open it
if ! pgrep Browserosaurus > /dev/null; then
  echo "Browserosaurus is not running"
  exit 1
fi

# Kill Browserosaurus
pkill Browserosaurus

# Define a function to wait for 50 milliseconds
wait_50ms() {
  sleep 0.05
}

# Wait until Browserosaurus is killed and re-open it
while true; do
  # Check if Browserosaurus is running
  if pgrep Browserosaurus > /dev/null; then
    echo "Browserosaurus is running"
  else
    echo "Browserosaurus is not running, opening it again"
    open -a Browserosaurus
    break
  fi

  # Wait for 50 milliseconds
  wait_50ms
done

kopach avatar Apr 18 '23 14:04 kopach

Following for a better solution

Saij avatar May 11 '23 10:05 Saij

@Saij Please use the "subscribe" button when you would like to follow issues on GitHub. When you comment you inadvertently send a notification to everyone already following the thread. They don't know what the notification is about, so like me, they click it and think "ooo, someone's found a solution" but then it's just a bump message. You can see how this may not be the best netiquette? Please don't answer that πŸ˜†

will-stone avatar May 11 '23 11:05 will-stone

Seems to be also a macOS problem : it was working well on 13.4.x but since 13.5 the issue is back (only displaying browser window on one virtual desktop, not all). Also having it with other apps (like LittleSnitch or auto-update dialog alert..). Very annoying, hope Apple will resolve it soon. Edit : deleting and recreating all desktops in Mission Control seems to work to have browseraurus window on all desktop again.

sushione avatar Aug 01 '23 14:08 sushione

@will-stone Are you okay with adding a feature(disabled by default) that will quit Browserosaurus after you select a browser? That solves the issue. I am willing to develop this feature if you agree to have it added.

joaovfsousa avatar Sep 20 '23 00:09 joaovfsousa

Sorry, not really. Although that works for you, it solves a problem I don’t have. Apple needs to fix this, or you could help Electron find a workaround.

However, this is open source. Fork the project and add your restarter code, there’s no requirement it has to make it to the parent project.

will-stone avatar Sep 20 '23 05:09 will-stone